Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](load) acquire latest token instead of oldest token in TokenManager #34424

Merged
merged 2 commits into from
May 6, 2024

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented May 6, 2024

Proposed changes

Previously, TokenManager always returns the oldest token, which may expire soon.
This PR changes it to return the latest token instead.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaijchen
Copy link
Contributor Author

kaijchen commented May 6, 2024

run buildall

1 similar comment
@kaijchen
Copy link
Contributor Author

kaijchen commented May 6, 2024

run buildall

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented May 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

PR approved by anyone and no changes requested.

@kaijchen kaijchen changed the title [fix](load) acquire latest token instead of oldest token [fix](load) acquire latest token instead of oldest token in TokenManager May 6, 2024
@doris-robot
Copy link

TPC-DS: Total hot run time: 186784 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9aeee99cc0668a81aed3e41607661dfce98f6688, data reload: false

query1	905	356	347	347
query2	6155	2472	2364	2364
query3	6651	208	207	207
query4	23304	21782	21905	21782
query5	4072	437	403	403
query6	259	176	164	164
query7	4585	304	296	296
query8	234	180	184	180
query9	8982	2404	2370	2370
query10	392	253	267	253
query11	15231	14629	14790	14629
query12	123	88	89	88
query13	1617	359	366	359
query14	8663	7689	8223	7689
query15	235	177	171	171
query16	8244	252	264	252
query17	1767	544	558	544
query18	2093	270	285	270
query19	324	147	154	147
query20	86	89	83	83
query21	190	125	125	125
query22	5070	4944	4888	4888
query23	33843	33205	33308	33205
query24	10603	2916	2767	2767
query25	593	360	358	358
query26	1163	150	153	150
query27	2190	312	325	312
query28	7054	2020	2021	2020
query29	839	605	600	600
query30	245	151	150	150
query31	932	730	726	726
query32	93	50	51	50
query33	727	245	242	242
query34	1025	463	467	463
query35	792	658	647	647
query36	1070	884	893	884
query37	133	67	64	64
query38	3191	2983	2968	2968
query39	1580	1533	1552	1533
query40	192	124	122	122
query41	41	39	39	39
query42	103	91	94	91
query43	555	540	539	539
query44	1210	712	724	712
query45	265	250	249	249
query46	1078	725	679	679
query47	1941	1834	1861	1834
query48	368	308	303	303
query49	860	379	386	379
query50	749	384	372	372
query51	6811	6705	6497	6497
query52	104	93	90	90
query53	341	274	271	271
query54	310	235	238	235
query55	78	79	72	72
query56	238	212	228	212
query57	1221	1108	1127	1108
query58	218	196	203	196
query59	3322	3160	3324	3160
query60	261	233	231	231
query61	90	87	84	84
query62	670	452	454	452
query63	303	283	272	272
query64	8625	7185	7164	7164
query65	3081	3049	3012	3012
query66	844	326	327	326
query67	15423	15377	15193	15193
query68	5219	522	525	522
query69	478	295	295	295
query70	1162	1070	992	992
query71	422	269	269	269
query72	7357	2529	2346	2346
query73	694	312	321	312
query74	6482	6153	6047	6047
query75	3422	2622	2624	2622
query76	3306	1052	1032	1032
query77	379	273	253	253
query78	11036	10180	10137	10137
query79	7443	522	513	513
query80	2195	444	482	444
query81	557	216	231	216
query82	1046	96	92	92
query83	267	168	163	163
query84	267	83	82	82
query85	2070	261	258	258
query86	526	284	308	284
query87	3323	3061	3070	3061
query88	4927	2318	2306	2306
query89	485	366	376	366
query90	2011	191	180	180
query91	119	100	94	94
query92	63	48	47	47
query93	5417	492	494	492
query94	1157	180	175	175
query95	390	297	299	297
query96	615	266	274	266
query97	3123	2934	2920	2920
query98	236	220	219	219
query99	1204	914	838	838
Total cold run time: 291955 ms
Total hot run time: 186784 ms

@xiaokang xiaokang added usercase Important user case type label dev/2.0.x labels May 6, 2024
Copy link
Contributor

@SaintBacchus SaintBacchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 14995f9 into apache:master May 6, 2024
25 of 29 checks passed
yiguolei pushed a commit that referenced this pull request May 6, 2024
…ger (#34424)

* [fix](load) acquire latest token instead of oldest token

* fixup
kaijchen added a commit to kaijchen/doris that referenced this pull request May 8, 2024
…ger (apache#34424)

* [fix](load) acquire latest token instead of oldest token

* fixup
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
…ger (apache#34424)

* [fix](load) acquire latest token instead of oldest token

* fixup
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.10-merged dev/2.1.3-merged dev/3.0.0-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants