[fix](move-memtable) ignore single replica load when move memtable #32845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 38373 ms |
TPC-DS: Total hot run time: 181411 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morrySnow
reviewed
Apr 9, 2024
| ConnectContext.get().getSessionVariable().getGroupCommit(), 0); | ||
| } else { | ||
| sink = new OlapTableSink((OlapTable) targetTable, olapTuple, targetPartitionIds, | ||
| analyzer.getContext().getSessionVariable().isEnableSingleReplicaInsert()); | ||
| enableSingleReplicaLoad); |
There was a problem hiding this comment.
do we need add this feature to nereids?
There was a problem hiding this comment.
Currently there is no single_replica_load option in nereids.
This PR is for fixing a problem.
If there is a need, we can create a new PR for that feature.
|
run cloud_p1 |
|
run buildall |
|
run fe_ut |
|
run buildall |
TPC-H: Total hot run time: 38555 ms |
TPC-DS: Total hot run time: 184712 ms |
ClickBench: Total hot run time: 30.59 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run p0 |
dataroaring
pushed a commit
that referenced
this pull request
Apr 24, 2024
…32845) Co-authored-by: Xin Liao <liaoxinbit@126.com>
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Aug 9, 2024
…pache#32845) Co-authored-by: Xin Liao <liaoxinbit@126.com>
dataroaring
pushed a commit
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Single replica load is not compatible with memtable on sink node.
Enabling single replica load when move memtable will cause missing location in OlapTableSink plan.
Ignore single replica load config when memtable on sink node is enabled.
Namely
enable_single_replica_loadconfig in fe.conf andenable_single_replica_insertin session variable.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...