Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](fe) Fix FE compiler issue introduced by #32532 #32811

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Mar 26, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@w41ter
Copy link
Contributor Author

w41ter commented Mar 26, 2024

run buildall

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 26, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 37808 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b26014938132328cc005efa6cb7c887503f7649d, data reload: false

------ Round 1 ----------------------------------
q1	17682	4129	4102	4102
q2	2130	157	154	154
q3	10637	1141	1187	1141
q4	10239	758	758	758
q5	7464	3012	2959	2959
q6	204	123	122	122
q7	1005	593	569	569
q8	9341	2021	1989	1989
q9	7213	6571	6533	6533
q10	8414	3419	3567	3419
q11	435	230	214	214
q12	445	197	193	193
q13	17795	2871	2859	2859
q14	225	201	201	201
q15	506	457	461	457
q16	499	372	371	371
q17	945	509	497	497
q18	7148	6547	6475	6475
q19	2264	1437	1351	1351
q20	546	249	245	245
q21	3506	3059	2909	2909
q22	347	298	290	290
Total cold run time: 108990 ms
Total hot run time: 37808 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4113	4060	4084	4060
q2	326	233	234	233
q3	2991	2834	2815	2815
q4	1876	1576	1552	1552
q5	5318	5319	5333	5319
q6	196	117	118	117
q7	2218	1859	1834	1834
q8	3148	3268	3276	3268
q9	8643	8616	8631	8616
q10	3785	3782	3761	3761
q11	549	446	444	444
q12	742	588	553	553
q13	16906	2850	2850	2850
q14	285	247	254	247
q15	497	475	480	475
q16	474	445	411	411
q17	1855	1497	1461	1461
q18	7604	7280	7054	7054
q19	1614	1505	1507	1505
q20	1921	1742	1716	1716
q21	4834	4734	4707	4707
q22	533	464	467	464
Total cold run time: 70428 ms
Total hot run time: 53462 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 181031 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b26014938132328cc005efa6cb7c887503f7649d, data reload: false

query1	948	377	345	345
query2	6546	1975	1870	1870
query3	6716	207	209	207
query4	31755	21459	21276	21276
query5	4334	410	387	387
query6	262	178	172	172
query7	4626	296	288	288
query8	233	180	174	174
query9	9701	2292	2278	2278
query10	601	244	252	244
query11	17163	14252	14198	14198
query12	138	86	82	82
query13	1620	399	413	399
query14	9569	7968	7553	7553
query15	255	199	193	193
query16	8165	258	261	258
query17	1944	583	559	559
query18	2110	287	277	277
query19	348	156	162	156
query20	93	85	89	85
query21	197	127	135	127
query22	4938	4769	4727	4727
query23	33390	32913	32410	32410
query24	11055	2933	2900	2900
query25	632	392	389	389
query26	1193	156	158	156
query27	2485	346	358	346
query28	7233	1872	1887	1872
query29	881	663	626	626
query30	308	153	152	152
query31	966	762	736	736
query32	90	64	58	58
query33	772	262	261	261
query34	989	467	487	467
query35	821	616	620	616
query36	1040	883	877	877
query37	120	68	65	65
query38	3591	3505	3442	3442
query39	1468	1449	1416	1416
query40	216	116	114	114
query41	51	48	47	47
query42	108	99	94	94
query43	480	443	440	440
query44	1191	737	711	711
query45	281	271	282	271
query46	1110	693	704	693
query47	1898	1840	1817	1817
query48	443	357	358	357
query49	1141	342	339	339
query50	775	366	364	364
query51	6820	6800	6734	6734
query52	113	88	93	88
query53	341	275	276	275
query54	314	234	236	234
query55	88	84	79	79
query56	256	227	230	227
query57	1196	1127	1145	1127
query58	234	215	213	213
query59	2853	2720	2705	2705
query60	263	248	248	248
query61	117	131	114	114
query62	668	449	456	449
query63	304	280	284	280
query64	5391	4156	4051	4051
query65	3111	3001	3039	3001
query66	855	367	349	349
query67	15385	14691	14579	14579
query68	7095	523	539	523
query69	621	376	381	376
query70	1277	1205	1115	1115
query71	528	271	261	261
query72	6647	2702	2550	2550
query73	734	309	307	307
query74	6758	6356	6434	6356
query75	3512	2225	2270	2225
query76	4978	884	910	884
query77	656	260	260	260
query78	10850	10168	10127	10127
query79	8207	530	530	530
query80	1506	371	370	370
query81	545	215	218	215
query82	1105	86	85	85
query83	204	144	142	142
query84	288	83	85	83
query85	1502	343	318	318
query86	476	302	287	287
query87	3798	3565	3539	3539
query88	4936	2286	2272	2272
query89	522	358	374	358
query90	1974	174	176	174
query91	172	134	134	134
query92	63	48	46	46
query93	6920	510	487	487
query94	1143	176	177	176
query95	441	336	328	328
query96	594	269	268	268
query97	2611	2453	2467	2453
query98	225	219	217	217
query99	1198	921	924	921
Total cold run time: 307385 ms
Total hot run time: 181031 ms

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit b26014938132328cc005efa6cb7c887503f7649d with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt BiteTheDDDDt merged commit 61c227d into apache:master Mar 26, 2024
34 of 37 checks passed
@w41ter w41ter deleted the fix/fe_compiler_issue branch March 26, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants