[fix](partial update) fix data correctness risk when load delete sign data into a table with sequence col #32574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data into a table with sequence col
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
PR approved by anyone and no changes requested. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
TeamCity be ut coverage result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 37541 ms |
TPC-DS: Total hot run time: 180867 ms |
TPC-H: Total hot run time: 38438 ms |
TPC-DS: Total hot run time: 180870 ms |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
yiguolei
pushed a commit
that referenced
this pull request
Mar 22, 2024
… data into a table with sequence col (#32574)
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Mar 22, 2024
… data into a table with sequence col (apache#32574)
zhannngchen
added a commit
to zhannngchen/incubator-doris
that referenced
this pull request
Jun 13, 2024
… data into a table with sequence col (apache#32574)
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…sign data into a table with sequence col (apache#32574) (apache#36228) cherry-pick apache#32574
bobhan1
pushed a commit
to bobhan1/doris
that referenced
this pull request
Jan 20, 2025
…sign data into a table with sequence col (apache#32574) (apache#36228) (apache#278) cherry-pick apache#32574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
In the current implementation of partial column update, in order to improve the efficiency of the load job, for rows
with delete sign, will automatically ignore the missing columns of the data complement, but when the table has sequence columns, the sequence columns are required to complement.
If a row is written with a delete sign, but the sequence columns are not filled in, the merge-on-read policy compaction will result in incorrect data.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...