[refactor](move-memtable) remove phmap and use shared ptr in delta writer v2 #30949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -30,12 +30,15 @@ DeltaWriterV2Map::DeltaWriterV2Map(UniqueId load_id, int num_use, DeltaWriterV2P | |||
|
|
|||
| DeltaWriterV2Map::~DeltaWriterV2Map() = default; | |||
|
|
|||
| DeltaWriterV2* DeltaWriterV2Map::get_or_create( | |||
| std::shared_ptr<DeltaWriterV2> DeltaWriterV2Map::get_or_create( | |||
There was a problem hiding this comment.
warning: method 'get_or_create' can be made static [readability-convert-member-functions-to-static]
Suggested change
| std::shared_ptr<DeltaWriterV2> DeltaWriterV2Map::get_or_create( | |
| static std::shared_ptr<DeltaWriterV2> DeltaWriterV2Map::get_or_create( |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 37327 ms |
TPC-DS: Total hot run time: 174237 ms |
ClickBench: Total hot run time: 30.61 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Feb 7, 2024
yiguolei
pushed a commit
that referenced
this pull request
Feb 8, 2024
…iter v2 (#30949) * [refactor](move-memtable) remove phmap and use shared ptr in delta writer v2 pool * ENABLE_FACTORY_CREATOR DeltaWriterV2
yiguolei
pushed a commit
that referenced
this pull request
Feb 16, 2024
…iter v2 (#30949) * [refactor](move-memtable) remove phmap and use shared ptr in delta writer v2 pool * ENABLE_FACTORY_CREATOR DeltaWriterV2
mymeiyi
pushed a commit
to mymeiyi/doris
that referenced
this pull request
Feb 19, 2024
…iter v2 (apache#30949) * [refactor](move-memtable) remove phmap and use shared ptr in delta writer v2 pool * ENABLE_FACTORY_CREATOR DeltaWriterV2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...