[fix](move-memtable) fix schema use-after-free in delta writer v2 #30254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -70,7 +70,8 @@ inline std::ostream& operator<<(std::ostream& ostr, const TabletStream& tablet_s | |||
| return ostr; | |||
| } | |||
|
|
|||
| Status TabletStream::init(OlapTableSchemaParam* schema, int64_t index_id, int64_t partition_id) { | |||
| Status TabletStream::init(std::shared_ptr<OlapTableSchemaParam> schema, int64_t index_id, | |||
There was a problem hiding this comment.
warning: method 'init' can be made static [readability-convert-member-functions-to-static]
be/src/runtime/load_stream.h:49:
- Status init(std::shared_ptr<OlapTableSchemaParam> schema, int64_t index_id, int64_t partition_id);
+ static Status init(std::shared_ptr<OlapTableSchemaParam> schema, int64_t index_id, int64_t partition_id);
TPC-H: Total hot run time: 39136 ms |
TPC-DS: Total hot run time: 176150 ms |
ClickBench: Total hot run time: 30.88 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
github-actions
bot
removed
the
approved
| @@ -70,7 +70,8 @@ inline std::ostream& operator<<(std::ostream& ostr, const TabletStream& tablet_s | |||
| return ostr; | |||
| } | |||
|
|
|||
| Status TabletStream::init(OlapTableSchemaParam* schema, int64_t index_id, int64_t partition_id) { | |||
| Status TabletStream::init(std::shared_ptr<OlapTableSchemaParam> schema, int64_t index_id, | |||
There was a problem hiding this comment.
warning: method 'init' can be made static [readability-convert-member-functions-to-static]
be/src/runtime/load_stream.h:49:
- Status init(std::shared_ptr<OlapTableSchemaParam> schema, int64_t index_id,
+ static Status init(std::shared_ptr<OlapTableSchemaParam> schema, int64_t index_id,
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38773 ms |
TPC-DS: Total hot run time: 186254 ms |
ClickBench: Total hot run time: 31.23 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run p0 |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
DeltaWriterV2are shared among sinks (OlapTableSinks).After #30098, sinks who complete first will not wait for stream close.
They will also not waiting for
DeltaWriterV2close.Use-after-free may happen because
DeltaWriterV2and its components are referencingTupleDescriptorandSlotDescriptorby raw pointer,Since
TupleDescriptorandSlotDescriptorare part ofOlapTableSchemaParamfrom a sink.This PR changes
OlapTableSchemaParampassed toDeltaWriterV2to be a shared pointer.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...