Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](read) remove logic of estimating count of rows to read in segment iterator to avoid wrong result of unique key (#29109) #29110

Merged
merged 1 commit into from
Dec 27, 2023
Merged

[fix](read) remove logic of estimating count of rows to read in segment iterator to avoid wrong result of unique key (#29109) #29110

merged 1 commit into from
Dec 27, 2023

Conversation

jacktengg
Copy link
Contributor

Proposed changes

Pick from #29109

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@jacktengg
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.83 seconds
stream load tsv: 566 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.8 seconds inserted 10000000 Rows, about 335K ops/s
storage size: 17162096331 Bytes

@jacktengg
Copy link
Contributor Author

run p1

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.80% (8006/21181)
Line Coverage: 29.48% (65067/220716)
Region Coverage: 28.94% (33452/115607)
Branch Coverage: 24.79% (17157/69196)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0137f89a77f6065583559ada1a872895b95a0cc5_0137f89a77f6065583559ada1a872895b95a0cc5/report/index.html

yiguolei
yiguolei approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 74b5ef0 into apache:branch-2.0 Dec 27, 2023
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Jan 4, 2024
@jacktengg
Revert "[fix](read) remove logic of estimating count of rows to read …
8934a95 
…in segment iterator to avoid wrong result of unique key (apache#29109) (apache#29110)"

This reverts commit 74b5ef0.

And fix bug: when avg_row_size > config::doris_scan_block_max_mb,
_opts.block_row_max will be set to 0, which will cause early EOF.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacktengg @doris-robot @yiguolei