Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[feature](load) enable memtable on sink node by default (#28963)" #29090

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Revert "[feature](load) enable memtable on sink node by default (#28963)" #29090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/en/docs/advanced/variables.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ Note that the comment must start with /*+ and can only follow the SELECT.
* `enable_memtable_on_sink_node`

<version since="2.1.0">
Whether to enable MemTable on DataSink node when loading data, default is true.
Whether to enable MemTable on DataSink node when loading data, default is false.
</version>

Build MemTable on DataSink node, and send segments to other backends through brpc streaming.
Expand Down
2 changes: 1 addition & 1 deletion docs/zh-CN/docs/advanced/variables.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ try (Connection conn = DriverManager.getConnection("jdbc:mysql://127.0.0.1:9030/
* `enable_memtable_on_sink_node`

<version since="2.1.0">
是否在数据导入中启用 MemTable 前移，默认为 true
是否在数据导入中启用 MemTable 前移，默认为 false
</version>

在 DataSink 节点上构建 MemTable，并通过 brpc streaming 发送 segment 到其他 BE。
Expand Down
2 changes: 1 addition & 1 deletion fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,7 +1342,7 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) {
public boolean truncateCharOrVarcharColumns = false;

@VariableMgr.VarAttr(name = ENABLE_MEMTABLE_ON_SINK_NODE, needForward = true)
public boolean enableMemtableOnSinkNode = true;
public boolean enableMemtableOnSinkNode = false;

@VariableMgr.VarAttr(name = LOAD_STREAM_PER_NODE)
public int loadStreamPerNode = 60;
Expand Down
Loading