Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test](decimal) add some cases about overflow #28198

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Dec 8, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@mrhhsg
Copy link
Member Author

mrhhsg commented Dec 8, 2023

run buildall

yiguolei
yiguolei previously approved these changes Dec 8, 2023
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Dec 8, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

PR approved by anyone and no changes requested.

@mrhhsg
Copy link
Member Author

mrhhsg commented Dec 9, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 9, 2023
@mrhhsg mrhhsg force-pushed the add_decimal_cases branch from ffc3e17 to 6b19393 Compare December 9, 2023 14:13
@mrhhsg
Copy link
Member Author

mrhhsg commented Dec 9, 2023

run buildall

@mrhhsg
Copy link
Member Author

mrhhsg commented Dec 10, 2023

run buildall

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 11, 2023
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 7c163fd into apache:master Dec 11, 2023
xzj7019 pushed a commit to xzj7019/doris that referenced this pull request Dec 13, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.4 reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants