[improve](group commit) Group commit support max filter ratio when rows is less than value in config #28139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| std::make_shared<doris::vectorized::FutureBlock>(); | ||
| future_block->swap(*(output_block.get())); | ||
| Status GroupCommitBlockSink::_add_blocks() { | ||
| DCHECK(_is_block_appended == false); |
There was a problem hiding this comment.
warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
Suggested change
| DCHECK(_is_block_appended == false); | |
| DCHECK(!_is_block_appended); |
mymeiyi
force-pushed
the
max_filter_ratio
branch
from
8ab8e3b to
168031e
Compare
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
mymeiyi
force-pushed
the
max_filter_ratio
branch
from
168031e to
dad45d5
Compare
|
run buildall |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Yukang-Lian
approved these changes
Dec 12, 2023
xzj7019
pushed a commit
to xzj7019/doris
that referenced
this pull request
Dec 13, 2023
…ws is less than value in config (apache#28139)
XuJianxu
pushed a commit
to XuJianxu/doris
that referenced
this pull request
Dec 14, 2023
…ws is less than value in config (apache#28139)
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Jan 12, 2024
…ws is less than value in config (apache#28139)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
if a load rows is less than
group_commit_memory_rows_for_max_filter_ratio(default10000), will check if the load meet themax_filter_ratio.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...