[Fix](inverted index) fix need read data optimize problem #28104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
bobhan1
pushed a commit
to bobhan1/doris
that referenced
this pull request
Dec 12, 2023
XuJianxu
pushed a commit
to XuJianxu/doris
that referenced
this pull request
Dec 14, 2023
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Dec 18, 2023
eldenmoon
added a commit
that referenced
this pull request
Dec 18, 2023
* change version to 2.0.3-rc05-var06 * [hotfix](jdbc catalog) fix jdbcmysqlclient npe (#28022) * [Fix](schema change) disable convert light schema change (#28205) * [Fix](inverted index) fix compound directory flush buffer error (#28191) * [Fix](inverted index) fix need read data optimize problem (#28104) --------- Co-authored-by: zy-kkk <zhongyk10@gmail.com> Co-authored-by: Luwei <814383175@qq.com> Co-authored-by: airborne12 <airborne08@gmail.com>
xiaokang
pushed a commit
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
This fix addresses an issue encountered when querying an inverted index table with a query like: SELECT COUNT() FROM table WHERE index_column > 1 AND index_column < 2.
In such scenarios, if the predicate index_column > 1 inadvertently skips using the index, but index_column < 2 utilizes the index for querying, the index_column gets incorrectly marked as not needing data read. This behavior leads to incorrect query results. The fix ensures accurate marking of columns for data reads in these cases.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...