Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement](multi-catalog)make location easier to modified, decoupling all storage with single location class #27874

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

wsjz
Copy link
Contributor

@wsjz wsjz commented Dec 1, 2023

Proposed changes

decoupling all storage with single location class

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@wsjz wsjz marked this pull request as ready for review December 4, 2023 01:41
morningman
morningman previously approved these changes Dec 4, 2023
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 4, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.83 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17163847866 Bytes

@wsjz
Copy link
Contributor Author

wsjz commented Dec 5, 2023

run external

@wsjz
Copy link
Contributor Author

wsjz commented Dec 5, 2023

run p0

@wsjz
Copy link
Contributor Author

wsjz commented Dec 5, 2023

run p1

@wsjz
Copy link
Contributor Author

wsjz commented Dec 5, 2023

run pipelinex_p0

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 5, 2023
@morningman
Copy link
Contributor

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.69 seconds
stream load tsv: 560 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 27.9 seconds inserted 10000000 Rows, about 358K ops/s
storage size: 17167084136 Bytes

@morningman morningman merged commit e431c2b into apache:master Dec 5, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

PR approved by at least one committer and no changes requested.

XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
…ing all storage with single location class (apache#27874)

decoupling all storage with single location class
morningman pushed a commit to morningman/doris that referenced this pull request Feb 5, 2024
…ing all storage with single location class (apache#27874)

decoupling all storage with single location class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.5-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants