Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](meta) show partitions with Limit for external HMS tables (27835) #27835

Merged
merged 1 commit into from
Dec 8, 2023
Merged

[fix](meta) show partitions with Limit for external HMS tables (27835) #27835

merged 1 commit into from
Dec 8, 2023

Conversation

Nitin-Kashyap
Copy link
Contributor

@Nitin-Kashyap Nitin-Kashyap commented Nov 30, 2023 •
edited
Loading

Proposed changes

This enhancement shall extend existing logic for SHOW PARTITIONS FROM to include: -

  • Limit/Offset
  • Where [partition name only] [equal operator and like operator]
  • Order by [partition name only]

Issue Number: close #27834

Sample output:
ShowPartitions

@Nitin-Kashyap Nitin-Kashyap changed the title [fix](meta) show partitions with Limit for external HMS tables. [fix](meta) show partitions with Limit for external HMS tables (27835) Nov 30, 2023
@Yulei-Yang
Copy link
Contributor

run buildall

@Nitin-Kashyap Nitin-Kashyap force-pushed the fix-showPartitionLimit branch 2 times, most recently from 56e9718 to dda01ee Compare December 2, 2023 07:14
@Nitin-Kashyap
Copy link
Contributor Author

run buildall

@Nitin-Kashyap Nitin-Kashyap force-pushed the fix-showPartitionLimit branch from dda01ee to bb331eb Compare December 2, 2023 12:32
@Nitin-Kashyap
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.96 seconds
stream load tsv: 582 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17164012441 Bytes

@Nitin-Kashyap Nitin-Kashyap force-pushed the fix-showPartitionLimit branch from bb331eb to e4be618 Compare December 3, 2023 12:42
@Nitin-Kashyap
Copy link
Contributor Author

run buildall

@morningman
Copy link
Contributor

Could you please add regression test cases for this feature?
you can refer to: https://doris.apache.org/community/developer-guide/regression-testing#e2e-test-with-external-data-sources to start to hive docker, and write test cases like:

regression-test/suites/external_table_p0/hive/test_prepare_hive_data_in_case.groovy

@Nitin-Kashyap Nitin-Kashyap force-pushed the fix-showPartitionLimit branch 2 times, most recently from b16672a to 2af4085 Compare December 4, 2023 17:11
@Nitin-Kashyap
Copy link
Contributor Author

Could you please add regression test cases for this feature? you can refer to: https://doris.apache.org/community/developer-guide/regression-testing#e2e-test-with-external-data-sources to start to hive docker, and write test cases like:

regression-test/suites/external_table_p0/hive/test_prepare_hive_data_in_case.groovy

fixed

@Nitin-Kashyap Nitin-Kashyap force-pushed the fix-showPartitionLimit branch from 2af4085 to 7044135 Compare December 4, 2023 17:12
@Nitin-Kashyap
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.64 seconds
stream load tsv: 560 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17163837619 Bytes

morningman
morningman approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

PR approved by anyone and no changes requested.

@Nitin-Kashyap Nitin-Kashyap requested a review from wsjz December 7, 2023 12:16
wsjz
wsjz approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@wsjz wsjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yiguolei
yiguolei approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 0733698 into apache:master Dec 8, 2023
@Nitin-Kashyap Nitin-Kashyap deleted the fix-showPartitionLimit branch December 8, 2023 18:36
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@Nitin-Kashyap
[fix](meta) show partitions with Limit for external HMS tables (27835) (
f8080ab 
apache#27835)

This enhancement shall extend existing logic for SHOW PARTITIONS FROM to include: -

Limit/Offset
Where [partition name only] [equal operator and like operator]
Order by [partition name only]
Issue Number: close apache#27834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

@yiguolei yiguolei yiguolei approved these changes

@wsjz wsjz wsjz approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.4 reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement](datalake)(meta) Limit/Where/Orderby doesnt work for SHOW PARITIONS on hive tables
7 participants
@Nitin-Kashyap @Yulei-Yang @doris-robot @morningman @yiguolei @wsjz @xiaokang