Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](load) return error instead of panic when slot and expr do not #27423

Merged
merged 3 commits into from
Nov 26, 2023
Merged

[fix](load) return error instead of panic when slot and expr do not #27423

merged 3 commits into from
Nov 26, 2023

Conversation

dataroaring
Copy link
Contributor

match

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@dataroaring
Copy link
Contributor Author

run buildall

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Nov 22, 2023
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' 
Tpch sf100 test result on commit e83ab5bf2ff576998e73d81ea712c5393f100baf, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4879	4675	4687	4675
q2	358	157	157	157
q3	2020	1938	1919	1919
q4	1381	1316	1249	1249
q5	3953	3966	4023	3966
q6	248	132	135	132
q7	1412	875	900	875
q8	2741	2764	2759	2759
q9	9755	10391	9531	9531
q10	3475	3541	3522	3522
q11	370	250	251	250
q12	440	290	291	290
q13	4563	3845	3818	3818
q14	312	289	283	283
q15	591	531	533	531
q16	656	577	590	577
q17	1122	945	939	939
q18	7707	7419	7337	7337
q19	1651	1670	1654	1654
q20	554	310	312	310
q21	4360	3954	3948	3948
q22	471	372	371	371
Total cold run time: 53019 ms
Total hot run time: 49093 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4579	4567	4558	4558
q2	342	239	260	239
q3	3993	4008	3992	3992
q4	2700	2691	2685	2685
q5	9605	9589	9715	9589
q6	245	124	125	124
q7	3000	2455	2472	2455
q8	4419	4411	4417	4411
q9	13150	13115	12934	12934
q10	4080	4163	4212	4163
q11	735	645	668	645
q12	991	800	813	800
q13	4265	3601	3594	3594
q14	378	336	359	336
q15	574	514	525	514
q16	735	664	668	664
q17	3875	3974	3895	3895
q18	9556	8874	8829	8829
q19	1796	1767	1733	1733
q20	2404	2103	2067	2067
q21	8851	8562	8587	8562
q22	875	799	787	787
Total cold run time: 81148 ms
Total hot run time: 77576 ms

@dataroaring
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 25, 2023
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 25, 2023
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' 
Tpch sf100 test result on commit 271fae50d6d9e3b16de072548a94d702d2794e31, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4970	4667	4666	4666
q2	351	166	157	157
q3	2031	1894	1881	1881
q4	1376	1248	1225	1225
q5	3953	3976	3983	3976
q6	252	132	135	132
q7	1421	882	882	882
q8	2775	2823	2799	2799
q9	9738	9594	9836	9594
q10	3443	3508	3528	3508
q11	383	255	248	248
q12	440	291	289	289
q13	4545	3810	3826	3810
q14	326	283	279	279
q15	587	532	540	532
q16	679	588	583	583
q17	1158	993	942	942
q18	7709	7368	7397	7368
q19	1706	1689	1676	1676
q20	576	320	301	301
q21	4331	3906	3969	3906
q22	477	374	369	369
Total cold run time: 53227 ms
Total hot run time: 49123 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4594	4582	4602	4582
q2	351	235	267	235
q3	4040	4002	3988	3988
q4	2680	2678	2675	2675
q5	9746	9634	9669	9634
q6	244	124	126	124
q7	3001	2483	2478	2478
q8	4431	4485	4443	4443
q9	12962	12906	12893	12893
q10	4061	4146	4173	4146
q11	810	644	664	644
q12	976	814	821	814
q13	4264	3537	3574	3537
q14	379	346	337	337
q15	577	529	517	517
q16	749	684	697	684
q17	3958	3841	3955	3841
q18	9361	8965	9101	8965
q19	1827	1784	1777	1777
q20	2387	2109	2055	2055
q21	8655	8557	8498	8498
q22	836	819	787	787
Total cold run time: 80889 ms
Total hot run time: 77654 ms

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.26 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 27 seconds loaded 2358488459 Bytes, about 83 MB/s
stream load orc: 70 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17099087736 Bytes

@dataroaring dataroaring merged commit b6dd43b into apache:master Nov 26, 2023
17 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 28, 2023
@dataroaring @seawinde
[fix](load) return error instead of panic when slot and expr do not (a…
80de94f 
…pache#27423)
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@dataroaring
[fix](load) return error instead of panic when slot and expr do not (a…
5ff8cb8 
…pache#27423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@kaijchen kaijchen kaijchen approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dataroaring @doris-robot @kaijchen @BiteTheDDDDt