-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor](routineload)Refactored routineload to improve scalability #19834
Merged
morningman
merged 10 commits into
apache:master
from
CalvinKirs:routineload-multi-table
May 23, 2023
Merged
[refactor](routineload)Refactored routineload to improve scalability #19834
morningman
merged 10 commits into
apache:master
from
CalvinKirs:routineload-multi-table
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The data source parameters are sunk into the specific data source class - Simplify some code logic to reduce code complexity - Provide a data source factory class to extract public logic
github-actions
bot
added
area/load
Issues or PRs related to all kinds of load
area/planner
Issues or PRs related to the query planner
area/routine load
labels
May 18, 2023
run buildall |
…utineload-multi-table
run buildall |
morningman
reviewed
May 22, 2023
run buildall |
morningman
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/load
Issues or PRs related to all kinds of load
area/planner
Issues or PRs related to the query planner
area/routine load
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...