Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor](routineload)Refactored routineload to improve scalability #19834

Merged
merged 10 commits into from
May 23, 2023

Conversation

CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented May 18, 2023

  • The data source parameters are sunk into the specific data source class
  • Simplify some code logic to reduce code complexity
  • Provide a data source factory class to extract public logic
  • Code that removes tests from production code. We should not include code for testing purposes in any production code.

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

- The data source parameters are sunk into the specific data source class
- Simplify some code logic to reduce code complexity
- Provide a data source factory class to extract public logic
@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/routine load labels May 18, 2023
@CalvinKirs
Copy link
Member Author

run buildall

@CalvinKirs CalvinKirs closed this May 19, 2023
@CalvinKirs CalvinKirs reopened this May 19, 2023
@CalvinKirs
Copy link
Member Author

run buildall

@morningman morningman self-assigned this May 22, 2023
@CalvinKirs
Copy link
Member Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit ebe3f6e into apache:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/routine load
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants