-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor](schema change) Using tablet schema shared ptr instead of raw ptr #11475
Conversation
Have you done a stress test to see whether this is a performance drop for this pr? |
No, because tablet schema is only used in control path, it is not on data path. And there will be a nightly performance benchmark in selectdb. If we find performance drops we could revert this PR. |
LGTM |
@wangbo I have done a simple performance test.
compare current branch with a47eff1 commit. |
beff0f3
to
2f46cde
Compare
2f46cde
to
86a1e95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Proposed changes
This is part of light weight schema change #10136
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...