[opt](inverted index) Inverted Index Dictionary Compression #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
zzzxl1993
force-pushed
the
202410211721
branch
from
bd09a41 to
17c8947
Compare
airborne12
reviewed
Nov 4, 2024
| @@ -1383,7 +1388,7 @@ void IndexWriter::indexCompaction(std::vector<lucene::store::Directory *> &src_d | |||
| proxOutputList.push_back(proxOut); | |||
| // Instantiate a new termInfosWriter which will write in directory | |||
| // for the segment name segment using the new merged fieldInfos | |||
| TermInfosWriter *termInfosWriter = _CLNEW TermInfosWriter(dest_dir, segment.c_str(), fieldInfos, termIndexInterval); | |||
| auto* termInfosWriter = _CLNEW STermInfosWriter<char>(dest_dir, segment.c_str(), fieldInfos, termIndexInterval); | |||
There was a problem hiding this comment.
Why we change STermInfosWriter here?
There was a problem hiding this comment.
Because we have two types in clucene: STermInfosWriter and TermInfosWriter, I only modified the code logic in STermInfosWriter. My expectation is to maintain only one process within STermInfosWriter.
xiaokang
reviewed
Nov 4, 2024
xiaokang
reviewed
Nov 4, 2024
airborne12
reviewed
Nov 5, 2024
| @@ -1879,7 +1884,8 @@ void IndexWriter::mergeTerms(bool hasProx, IndexVersion indexVersion) { | |||
| TermInfo termInfo; | |||
| termInfo.set(dfs[i], freqPointer, proxPointer, (int32_t) (skipPointer - freqPointer)); | |||
| // Write a new TermInfo | |||
| termInfosWriter->add(smallestTerm, &termInfo); | |||
| std::string cur_term = lucene_wcstoutf8string(smallestTerm->text(), smallestTerm->textLength()); | |||
There was a problem hiding this comment.
Find solution to avoid lucene_wcstoutf8string function call here.
zzzxl1993
force-pushed
the
202410211721
branch
from
3d2ad23 to
a4c9c44
Compare
zzzxl1993
force-pushed
the
202410211721
branch
from
a4c9c44 to
d8817bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.