Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve]improve group commit logic #413

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

vinlee19
Copy link
Contributor

@vinlee19 vinlee19 commented Jul 1, 2024

Proposed changes

Issue Number: close #xxx

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@JNSimba
Copy link
Member

JNSimba commented Jul 2, 2024

@vinlee19 Thank you, please rebase master

@vinlee19
Copy link
Contributor Author

vinlee19 commented Jul 2, 2024

@vinlee19 Thank you, please rebase master

done

Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit ba21aab into apache:master Jul 2, 2024
6 checks passed
@JNSimba JNSimba mentioned this pull request Jul 9, 2024
PeatBoy pushed a commit to hyperpaas/doris-flink-connector that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants