-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][dolphinscheduler-task-seatunnel] script resource file path error #15621
[Bug][dolphinscheduler-task-seatunnel] script resource file path error #15621
Conversation
@caishunfeng @SbloodyS @zhuangchong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please link this pr to your issue. @cqutwangyu
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15621 +/- ##
============================================
- Coverage 38.56% 38.56% -0.01%
+ Complexity 4790 4789 -1
============================================
Files 1316 1316
Lines 45043 45043
Branches 4823 4823
============================================
- Hits 17372 17371 -1
Misses 25780 25780
- Partials 1891 1892 +1 ☔ View full report in Codecov by Sentry. |
ok, link to #15156 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
包含子任务的工作流,子工作流中有个别任务失败,重跑失败任务时,子工作流中的任务会全部重跑,这个bug会在这个版本修复吗? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Please retry analysis of this Pull-Request directly on SonarCloud |
Purpose of the pull request
fix #15156
fix script resource file path error
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md