Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][dolphinscheduler-task-seatunnel] script resource file path error #15621

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

cqutwangyu
Copy link
Contributor

@cqutwangyu cqutwangyu commented Feb 23, 2024

Purpose of the pull request

fix #15156
fix script resource file path error
image
image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@cqutwangyu cqutwangyu changed the title [Fix][dolphinscheduler-task-seatunnel] script resource file path error [Bug][dolphinscheduler-task-seatunnel] script resource file path error Feb 23, 2024
@cqutwangyu
Copy link
Contributor Author

@caishunfeng @SbloodyS @zhuangchong
please cc

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link this pr to your issue. @cqutwangyu

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.56%. Comparing base (f14749a) to head (c829e2f).

❗ Current head c829e2f differs from pull request most recent head 157f039. Consider uploading reports for the commit 157f039 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15621      +/-   ##
============================================
- Coverage     38.56%   38.56%   -0.01%     
+ Complexity     4790     4789       -1     
============================================
  Files          1316     1316              
  Lines         45043    45043              
  Branches       4823     4823              
============================================
- Hits          17372    17371       -1     
  Misses        25780    25780              
- Partials       1891     1892       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cqutwangyu
Copy link
Contributor Author

Please link this pr to your issue. @cqutwangyu

ok, link to #15156

@SbloodyS SbloodyS added bug Something isn't working first time contributor First-time contributor 3.2.2 labels Feb 23, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone Feb 23, 2024
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxiangmin
Copy link

包含子任务的工作流,子工作流中有个别任务失败,重跑失败任务时,子工作流中的任务会全部重跑,这个bug会在这个版本修复吗?

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@SbloodyS SbloodyS merged commit 0000851 into apache:dev Feb 27, 2024
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 backend bug Something isn't working first time contributor First-time contributor ready-to-merge
Projects
None yet
5 participants