Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TaskGroupQueue updateTime when force start #15510

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added 3.2.1 and removed backend labels Jan 18, 2024
@mergeable mergeable bot removed the 3.2.1 label Jan 18, 2024
@ruanwenjun ruanwenjun added bug Something isn't working backend labels Jan 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (16c97ef) 38.01% compared to head (e488f0f) 38.02%.

❗ Current head e488f0f differs from pull request most recent head 89b57f4. Consider uploading reports for the commit 89b57f4 to get more accurate results

Files Patch % Lines
...cheduler/api/service/impl/ExecutorServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15510   +/-   ##
=========================================
  Coverage     38.01%   38.02%           
- Complexity     4691     4692    +1     
=========================================
  Files          1304     1304           
  Lines         44811    44812    +1     
  Branches       4803     4803           
=========================================
+ Hits          17037    17038    +1     
- Misses        25922    25923    +1     
+ Partials       1852     1851    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 0dc373d into apache:dev Jan 18, 2024
56 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_forceStartUpdate branch January 18, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants