【Master】【Bug】Fix a bug, When the worker service offline, workerNodeInfo cache in master cannot delete the offline worker

[alei1206]

Purpose of the pull request

Fix #15370
When the worker service goes offline, delete the worker information from the workerNodeInfo cache in master

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (feb3023) 38.02% compared to head (67c8d0e) 38.10%.

❗ Current head 67c8d0e differs from pull request most recent head 38de349. Consider uploading reports for the commit 38de349 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##                dev   #15459      +/-   ##
============================================
+ Coverage     38.02%   38.10%   +0.08%     
- Complexity     4693     4698       +5     
============================================
  Files          1304     1304              
  Lines         44812    44818       +6     
  Branches       4804     4804              
============================================
+ Hits          17040    17079      +39     
+ Misses        25921    25885      -36     
- Partials       1851     1854       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alei1206]

@SbloodyS Hi，Do you think there are any other problem with this PR

[SbloodyS]

Could you add some UT for it? @alei1206

[alei1206]

Could you add some UT for it? @alei1206

@SbloodyS Hi, Unit tests have been added.

[alei1206]

Could you add some UT for it? @alei1206

@SbloodyS Hi, Unit tests have been added.

@SbloodyS Hi, do you have other suggestions about this code?

[rickchengx]

HI, @alei1206 please Run 'mvn spotless:apply' to fix the code style

[alei1206]

HI, @alei1206 please Run 'mvn spotless:apply' to fix the code style

@rickchengx Hi，I have modified the code style using mvn spotless:apply. Please check again.

[sonarqubecloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[ruanwenjun]

Does anyone see the todo here? Why only handle the delete event, in fact this is not a bug, the task dispatch failed it will retry until the master refresh worker node, in this PR only handle the delete event, but still miss add event is not a good pr.

[alei1206]

Does anyone see the todo here? Why only handle the delete event, in fact this is not a bug, the task dispatch failed it will retry until the master refresh worker node, in this PR only handle the delete event, but still miss add event is not a good pr.

@ruanwenjun Hi, I think, when master refresh worker node， only add new worker server to cache, but not delete the offline worker。 if we not handle the delete event, the offline worker server are always in the cache. Additionally, updateWorkerNodes() will get all the worker nodes in zk and add them to the cache, so I think, we shouldn't need to handle the add event.