Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for defaultTenantEnabled #15391

Merged

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jan 2, 2024

Purpose of the pull request

  • Add config to open/close default tenant.
  • Close default tenant by default.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added feature new feature improvement make more easy to user or prompt friendly and removed feature new feature labels Jan 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e5a5128) 38.12% compared to head (4ddb982) 38.12%.

❗ Current head 4ddb982 differs from pull request most recent head 245abdc. Consider uploading reports for the commit 245abdc to get more accurate results

Files Patch % Lines
...server/worker/utils/TaskExecutionContextUtils.java 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15391   +/-   ##
=========================================
  Coverage     38.12%   38.12%           
- Complexity     4697     4698    +1     
=========================================
  Files          1299     1299           
  Lines         44774    44773    -1     
  Branches       4799     4798    -1     
=========================================
  Hits          17068    17068           
- Misses        25855    25858    +3     
+ Partials       1851     1847    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addSwitchForDefaultTenant branch from 47b0590 to 00a8bdd Compare January 4, 2024 06:03
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addSwitchForDefaultTenant branch from 00a8bdd to 245abdc Compare January 6, 2024 09:08
Copy link

sonarqubecloud bot commented Jan 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

17.6% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@ruanwenjun ruanwenjun merged commit 6c1e001 into apache:dev Jan 6, 2024
54 of 55 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_addSwitchForDefaultTenant branch January 29, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend document improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants