[Bug][SqlTask] Set maxRows in SqlTask

[ruanwenjun]

Purpose of the pull request

I find when we select from a large table, the limit configuration in the ui will not be used, this will cause the worker oom.

Once the result count is larger than limit, it will not be used, so we don't need to fetch all records.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

[codecov-commenter]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f8a44ff) 37.80% compared to head (b798667) 37.81%.

❗ Current head b798667 differs from pull request most recent head 6e90816. Consider uploading reports for the commit 6e90816 to get more accurate results

Files	Patch %	Lines
...ache/dolphinscheduler/plugin/task/sql/SqlTask.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##                dev   #15342   +/-   ##
=========================================
  Coverage     37.80%   37.81%           
  Complexity     4701     4701           
=========================================
  Files          1304     1304           
  Lines         45221    45216    -5     
  Branches       4859     4858    -1     
=========================================
+ Hits          17098    17099    +1     
+ Misses        26260    26254    -6     
  Partials       1863     1863           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[EricGao888]

Besides making the limit take effect, I think probably we still need to add some limits by default for something like select *. If users do not add limit explicitly, it seems they still could make worker OOM.

[qingwli]

ERROR: 1 dead links found!
[✖] https://twitter.com/dolphinschedule → Status: 400

But I test works well locally

[EricGao888]

ERROR: 1 dead links found!
[✖] https://twitter.com/dolphinschedule → Status: 400

But I test works well locally

@qingwli It could happen. The network of github actions machine is different from your local network.

[ruanwenjun]

Besides making the limit take effect, I think probably we still need to add some limits by default for something like select *. If users do not add limit explicitly, it seems they still could make worker OOM.

We will use default number QUERY_LIMIT if user doesn't set limit.

[EricGao888]

Besides making the limit take effect, I think probably we still need to add some limits by default for something like select *. If users do not add limit explicitly, it seems they still could make worker OOM.

We will use default number QUERY_LIMIT if user doesn't set limit.

Got it

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarCloud