[Bug] fail-fast for dependent check #15197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dyqer
requested review from
caishunfeng,
SbloodyS and
zhuangchong
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15197 +/- ##
============================================
- Coverage 38.19% 38.15% -0.05%
+ Complexity 4677 4661 -16
============================================
Files 1278 1278
Lines 44481 44481
Branches 4782 4783 +1
============================================
- Hits 16988 16970 -18
- Misses 25631 25649 +18
Partials 1862 1862 ☔ View full report in Codecov by Sentry. |
|
@ruanwenjun @zhuangchong can you help review? |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Refer #15229
If the upstream process instance is failed, the result will be cached and won't be update, so we should return failed immediately and finish the dependent task