Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][workFlow] online,offline and delete Button, edge Popconfirm message does not take effect #15018

Merged
merged 3 commits into from
Oct 12, 2023
Merged

[Improvement][workFlow] online,offline and delete Button, edge Popconfirm message does not take effect #15018

merged 3 commits into from
Oct 12, 2023

Conversation

ly109974
Copy link
Contributor

@ly109974 ly109974 commented Oct 12, 2023 •
edited by zhuangchong
Loading

fix #15017

@github-actions github-actions bot added the UI ui and front end related label Oct 12, 2023
@zhuangchong zhuangchong added improvement make more easy to user or prompt friendly ready-to-merge labels Oct 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #15018 (ca023c1) into dev (1f67e68) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head ca023c1 differs from pull request most recent head 19ddc09. Consider uploading reports for the commit 19ddc09 to get more accurate results

@@             Coverage Diff              @@
##                dev   #15018      +/-   ##
============================================
+ Coverage     38.77%   38.90%   +0.12%     
- Complexity     4576     4611      +35     
============================================
  Files          1236     1236              
  Lines         43415    43449      +34     
  Branches       4792     4809      +17     
============================================
+ Hits          16836    16905      +69     
+ Misses        24706    24671      -35     
  Partials       1873     1873

see 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SbloodyS SbloodyS added the 3.2.1 label Oct 12, 2023
@SbloodyS SbloodyS added this to the 3.2.1 milestone Oct 12, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zhuangchong zhuangchong merged commit d983e36 into apache:dev Oct 12, 2023
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 30, 2023
@ly109974 @xdu-chenrj
improvement (apache#15018)
2805a3c
@ly109974 ly109974 deleted the dev-button branch December 20, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuangchong zhuangchong zhuangchong approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

Assignees

@ly109974 ly109974

Labels
3.2.1 improvement make more easy to user or prompt friendly ready-to-merge UI ui and front end related
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

[Improvement][workFlow] online,offline and delete Button, edge Popconfirm message does not take effect
4 participants
@ly109974 @codecov-commenter @zhuangchong @SbloodyS