Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-14805] Task definition log may be written twice #15016

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

HomminLee
Copy link
Contributor

Purpose of the pull request

close #14805.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@mergeable mergeable bot removed the backend label Oct 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (3.1.9-prepare@b40a737). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2e15096 differs from pull request most recent head f5839e7. Consider uploading reports for the commit f5839e7 to get more accurate results

@@               Coverage Diff                @@
##             3.1.9-prepare   #15016   +/-   ##
================================================
  Coverage                 ?   38.21%           
  Complexity               ?     3989           
================================================
  Files                    ?     1000           
  Lines                    ?    36993           
  Branches                 ?     4278           
================================================
  Hits                     ?    14136           
  Misses                   ?    21238           
  Partials                 ?     1619           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 14 Bugs
Vulnerability B 9 Vulnerabilities
Security Hotspot E 4 Security Hotspots
Code Smell A 864 Code Smells

28.2% 28.2% Coverage
2.5% 2.5% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SbloodyS SbloodyS added the 3.1.x for 3.1.x version label Oct 12, 2023
@SbloodyS SbloodyS added this to the 3.1.9 milestone Oct 12, 2023
@SbloodyS SbloodyS added bug Something isn't working backend labels Oct 12, 2023
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS merged commit f4fae98 into apache:3.1.9-prepare Nov 8, 2023
1 check failed
@zhuangchong zhuangchong added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version backend bug Something isn't working release cherry-pick Mark this issue/PR had cherry-pick for release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants