Fix When the task instance status is 'STOP' #14967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songjianet
previously approved these changes
Sep 27, 2023
Codecov Report
@@ Coverage Diff @@
## dev #14967 +/- ##
============================================
- Coverage 38.97% 38.95% -0.03%
+ Complexity 4601 4599 -2
============================================
Files 1231 1231
Lines 43354 43354
Branches 4795 4795
============================================
- Hits 16896 16887 -9
- Misses 24583 24594 +11
+ Partials 1875 1873 -2 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fuchanghai
reviewed
Sep 27, 2023
EricGao888
approved these changes
Sep 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 30, 2023
* Fix When the task instance status is 'STOP' * Fix ITaskState types sort by ID --------- Co-authored-by: Eric Gao <ericgao.apache@gmail.com> Co-authored-by: xiangzihao <460888207@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Fix When the task instance status is 'STOP', and avoid the 'STOP' state causing the
stateOptionnot to match and reporting an errorVerify this pull request
This pull request is already covered by existing tests, such as (please describe tests).
Manually verified the change by testing locally.