-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature-14542][K8S] add prometheus serviceMonitor #14539
Conversation
Signed-off-by: Gallardot <gallardot@apache.org>
Codecov Report
@@ Coverage Diff @@
## dev #14539 +/- ##
=========================================
Coverage 38.68% 38.68%
- Complexity 4576 4578 +2
=========================================
Files 1241 1241
Lines 43568 43568
Branches 4828 4826 -2
=========================================
+ Hits 16853 16856 +3
+ Misses 24847 24844 -3
Partials 1868 1868 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Hi @EricGao888, would you like to take a look? |
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: Gallardot <gallardot@apache.org> Co-authored-by: Eric Gao <ericgao.apache@gmail.com> (cherry picked from commit f5be784)
Signed-off-by: Gallardot <gallardot@apache.org> Co-authored-by: Eric Gao <ericgao.apache@gmail.com>
Purpose of the pull request
Adding prometheus serviceMonitor will help improve the overall project observability
close #14542
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
enable serviceMonitor with values
prometheus's target page will see the following effect
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md