Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-14542][K8S] add prometheus serviceMonitor #14539

Merged
merged 5 commits into from
Jul 17, 2023

Conversation

Gallardot
Copy link
Member

@Gallardot Gallardot commented Jul 13, 2023

Purpose of the pull request

Adding prometheus serviceMonitor will help improve the overall project observability

close #14542

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

enable serviceMonitor with values

master:
  service:
    serviceMonitor:
      enabled: true

worker:
  service:
    serviceMonitor:
      enabled: true

alert:
  service:
    serviceMonitor:
      enabled: true

api:
  service:
    serviceMonitor:
      enabled: true

prometheus's target page will see the following effect

image

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Signed-off-by: Gallardot <gallardot@apache.org>
@Gallardot Gallardot requested a review from caishunfeng as a code owner July 13, 2023 09:41
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #14539 (d5e9dff) into dev (027d66d) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head d5e9dff differs from pull request most recent head dfae496. Consider uploading reports for the commit dfae496 to get more accurate results

@@            Coverage Diff            @@
##                dev   #14539   +/-   ##
=========================================
  Coverage     38.68%   38.68%           
- Complexity     4576     4578    +2     
=========================================
  Files          1241     1241           
  Lines         43568    43568           
  Branches       4828     4826    -2     
=========================================
+ Hits          16853    16856    +3     
+ Misses        24847    24844    -3     
  Partials       1868     1868           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Gallardot Gallardot changed the title [Feature][K8S] add prometheus serviceMonitor [Feature-14542][K8S] add prometheus serviceMonitor Jul 13, 2023
@Radeity Radeity added this to the 3.2.0 milestone Jul 17, 2023
@Radeity Radeity added the 3.2.0 for 3.2.0 version label Jul 17, 2023
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Radeity
Copy link
Member

Radeity commented Jul 17, 2023

Hi @EricGao888, would you like to take a look?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Radeity Radeity merged commit f5be784 into apache:dev Jul 17, 2023
@Gallardot Gallardot deleted the monitor-service branch July 17, 2023 08:36
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
Signed-off-by: Gallardot <gallardot@apache.org>
Co-authored-by: Eric Gao <ericgao.apache@gmail.com>
(cherry picked from commit f5be784)
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
Signed-off-by: Gallardot <gallardot@apache.org>
Co-authored-by: Eric Gao <ericgao.apache@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version feature new feature kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][K8S] improve the overall project observability on K8S
4 participants