Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] ddl without drop exists #14128

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Conversation

zhongjiajie
Copy link
Member

@zhongjiajie zhongjiajie commented May 17, 2023

When I re execute the sql files, will raise error due to table already exists

@zhongjiajie zhongjiajie changed the title fix: ddl without drop exists [WIP] fix: ddl without drop exists May 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d6af51) 38.38% compared to head (80757d5) 38.38%.

❗ Current head 80757d5 differs from pull request most recent head 813aa1c. Consider uploading reports for the commit 813aa1c to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #14128      +/-   ##
============================================
- Coverage     38.38%   38.38%   -0.01%     
+ Complexity     4747     4746       -1     
============================================
  Files          1305     1305              
  Lines         44846    44846              
  Branches       4810     4810              
============================================
- Hits          17213    17212       -1     
  Misses        25759    25759              
- Partials       1874     1875       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zhongjiajie zhongjiajie marked this pull request as ready for review July 13, 2023 08:56
@zhongjiajie zhongjiajie changed the title [WIP] fix: ddl without drop exists fix: ddl without drop exists Jul 13, 2023
@zhongjiajie zhongjiajie added this to the 3.2.0 milestone Jul 13, 2023
@zhongjiajie zhongjiajie added the 3.2.0 for 3.2.0 version label Jul 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zhongjiajie zhongjiajie modified the milestones: 3.2.0, 3.3.0 Aug 30, 2023
Copy link

mergeable bot commented Feb 5, 2024

⚠️ This PR do not change database DDL synchronize.

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx rickchengx added ready-to-merge improvement make more easy to user or prompt friendly bug Something isn't working and removed sql not sync improvement make more easy to user or prompt friendly labels Feb 5, 2024
Copy link

sonarqubecloud bot commented Feb 5, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@rickchengx rickchengx merged commit d8e820c into apache:dev Feb 5, 2024
62 of 63 checks passed
@zhongjiajie zhongjiajie deleted the b-ddl-without-drop branch February 6, 2024 10:23
@zhongjiajie
Copy link
Member Author

thanks

zhongjiajie added a commit that referenced this pull request Feb 6, 2024
Co-authored-by: Rick Cheng <rickchengx@gmail.com>
(cherry picked from commit d8e820c)
@SbloodyS SbloodyS changed the title fix: ddl without drop exists [Fix] ddl without drop exists Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend bug Something isn't working ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants