Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-13917][UI] Fix item, workflow, and task parameters in dependent task nodes can be searched #13918

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

zhuangchong
Copy link
Contributor

Purpose of the pull request

this pr closes #13917

fix ui:

iShot_2023-04-12_18 04 51

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@zhuangchong zhuangchong requested a review from songjianet as a code owner April 12, 2023 10:25
@github-actions github-actions bot added the UI ui and front end related label Apr 12, 2023
@zhuangchong zhuangchong added bug Something isn't working 3.1.x for 3.1.x version labels Apr 12, 2023
@zhuangchong zhuangchong added this to the 3.1.6 milestone Apr 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #13918 (e2f6b3f) into dev (f9f88cb) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head e2f6b3f differs from pull request most recent head 4890a2f. Consider uploading reports for the commit 4890a2f to get more accurate results

@@             Coverage Diff              @@
##                dev   #13918      +/-   ##
============================================
- Coverage     38.90%   38.86%   -0.04%     
+ Complexity     4458     4453       -5     
============================================
  Files          1158     1158              
  Lines         42429    42429              
  Branches       4776     4776              
============================================
- Hits          16506    16491      -15     
- Misses        24107    24121      +14     
- Partials       1816     1817       +1     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@calvinjiang calvinjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@calvinjiang calvinjiang merged commit c3de282 into apache:dev Apr 13, 2023
@zhuangchong zhuangchong deleted the ui-dependent-display branch April 13, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version bug Something isn't working UI ui and front end related
Projects
None yet
3 participants