[improve-#13045] after a submit failure, stop the processInstance to avoid an endless loop #13051
Conversation
fuchanghai
requested review from
caishunfeng,
SbloodyS and
ruanwenjun
as code owners
SbloodyS
added
improvement
fuchanghai
force-pushed
the
improve-#13045
branch
from
99f77b2 to
fb7e0a5
Compare
Codecov Report
@@ Coverage Diff @@
## dev #13051 +/- ##
============================================
- Coverage 39.57% 39.48% -0.09%
- Complexity 4375 4381 +6
============================================
Files 1097 1102 +5
Lines 41288 41453 +165
Branches 4723 4740 +17
============================================
+ Hits 16340 16368 +28
- Misses 23133 23265 +132
- Partials 1815 1820 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
SonarCloud Quality Gate failed. |
|
cc @ruanwenjun |
|
@caishunfeng please take a look , thx |
| if (e instanceof SQLException) { | ||
| return WorkflowSubmitStatue.FAILED; | ||
| } else { | ||
| return WorkflowSubmitStatue.ERROR; | ||
| } |
There was a problem hiding this comment.
I suggest not to distinguish these two types of error, rather, DB failure will keep writing logs.
|
if exception is not type of sqlexception。master will print log until have not enough space
…---Original---
From: "Aaron ***@***.***>
Date: Thu, Feb 9, 2023 21:27 PM
To: ***@***.***>;
Cc: ***@***.***>;"State ***@***.***>;
Subject: Re: [apache/dolphinscheduler] [improve-#13045] add max submit numberof workflow (PR #13051)
@Radeity commented on this pull request.
In dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
> + if (e instanceof SQLException) { + return WorkflowSubmitStatue.FAILED; + } else { + return WorkflowSubmitStatue.ERROR; + }
I suggest not to distinguish these two types of error, rather, DB failure will keep writing logs.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
I mean you don't have to add |
|
ruanwenjun recommend that if exception is not type of sqlexception ，we should reduce the count ，because we can not to deal with it。
…---Original---
From: "Aaron ***@***.***>
Date: Thu, Feb 9, 2023 21:51 PM
To: ***@***.***>;
Cc: ***@***.***>;"State ***@***.***>;
Subject: Re: [apache/dolphinscheduler] [improve-#13045] add max submit numberof workflow (PR #13051)
if exception is not type of sqlexception。master will print log until have not enough space
I mean you don't have to add Error state, whether there's a db error or other types of error, they can both update the count number.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
I've noticed that, i think he just reminds that if you update db, it will throw exception, rather recommend you ignore sql exception. |
sql exception maybe caused by db crash which is can be resumed ,so I have to keep trying again ,and don't need reduce count |
I don't think so. Now that we allow task to retry, we just assume that they are possible to return to normal, db crash or network failure, etc. If the task can not recover, we can directly stop it and don't even have to keep this count. SO, we set this count number for two reasons:
|
...src/main/java/org/apache/dolphinscheduler/server/master/event/WorkflowStartEventHandler.java
Show resolved
Hide resolved
fuchanghai
requested review from
caishunfeng
and removed request for
SbloodyS and
ruanwenjun
|
@caishunfeng @ruanwenjun PTAL |
fuchanghai
changed the title
Co-authored-by: Wenjun Ruan <wenjun@apache.org>
|
Kudos, SonarCloud Quality Gate passed! |
zhuangchong
added
release cherry-pick 3.1.x
3.1.x
…Instance to avoid an endless loop #13051
zhuangchong
added
the
release cherry-pick
Purpose of the pull request
add max submit number of workflow
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
this close: #13045