Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][sql] Add unique key to process_definition_log avoid TooManyResultExpection #12503

Merged
merged 5 commits into from
Oct 25, 2022
Merged

[fix][sql] Add unique key to process_definition_log avoid TooManyResultExpection #12503

merged 5 commits into from
Oct 25, 2022

Conversation

hiSandog
Copy link
Contributor

@hiSandog hiSandog commented Oct 23, 2022 •
edited by zhongjiajie
Loading

After I edit the workflow, I save it.
The interface response speed is too slow.
Let me think I didn't save it，So I saved it again.
The result saved successfully both times.
But in the t_ds_process_definition_log table, the version values are the same.
Causes the list interface to report an error.
image
This should be addressed first at the table structure level.
fix: #12504

@hiSandog hiSandog requested a review from zhongjiajie as a code owner October 23, 2022 03:50
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022 •
edited
Loading

Codecov Report

Merging #12503 (21f7df5) into dev (b936b88) will increase coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #12503      +/-   ##
============================================
+ Coverage     39.45%   39.61%   +0.16%     
+ Complexity     4217     4189      -28     
============================================
  Files          1041     1038       -3     
  Lines         39160    38843     -317     
  Branches       4478     4449      -29     
============================================
- Hits          15449    15388      -61     
+ Misses        21942    21711     -231     
+ Partials       1769     1744      -25
Impacted Files Coverage Δ
...pache/dolphinscheduler/common/utils/DateUtils.java 68.30% <0.00%> (-5.80%) ⬇️
...e/dolphinscheduler/service/utils/ProcessUtils.java 27.95% <0.00%> (-0.62%) ⬇️
...server/worker/utils/TaskExecutionCheckerUtils.java 8.00% <0.00%> (-0.20%) ⬇️
...nscheduler/service/process/ProcessServiceImpl.java 28.58% <0.00%> (-0.05%) ⬇️
...e/dolphinscheduler/api/aspect/AccessLogAspect.java 81.66% <0.00%> (ø)
...e/dolphinscheduler/api/utils/ClusterConfUtils.java 28.57% <0.00%> (ø)
...pache/dolphinscheduler/service/utils/LogUtils.java 92.59% <0.00%> (ø)
...che/dolphinscheduler/service/utils/ParamUtils.java 69.56% <0.00%> (ø)
...he/dolphinscheduler/service/utils/CommonUtils.java 12.96% <0.00%> (ø)
...he/dolphinscheduler/service/utils/LoggerUtils.java 3.84% <0.00%> (ø)
... and 115 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hiSandog hiSandog changed the title [fix][sql] Add unique key to t_ds_process_definition_log [fix][sql] -12504 Add unique key to t_ds_process_definition_log Oct 23, 2022
@hiSandog hiSandog changed the title [fix][sql] -12504 Add unique key to t_ds_process_definition_log [fix-12504][sql] Add unique key to t_ds_process_definition_log Oct 23, 2022
@SbloodyS SbloodyS added bug Something isn't working 3.0.x labels Oct 24, 2022
@SbloodyS SbloodyS added this to the 3.0.2 milestone Oct 24, 2022
@SbloodyS SbloodyS requested a review from caishunfeng October 24, 2022 01:56
SbloodyS
SbloodyS reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use english in the commit message.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@EricGao888
Copy link
Member

May I ask whether we are going to add this patch to 3.0.2?

@hiSandog
Copy link
Contributor Author

May I ask whether we are going to add this patch to 3.0.2?

yes

zhongjiajie
zhongjiajie approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, And I think it should in version 3.0.2.

@zhongjiajie zhongjiajie merged commit 97a0771 into apache:dev Oct 25, 2022
@zhongjiajie zhongjiajie changed the title [fix-12504][sql] Add unique key to t_ds_process_definition_log [fix][sql] Add unique key to process_definition_log avoid TooManyResultExpection Oct 25, 2022
EricGao888 pushed a commit to EricGao888/dolphinscheduler that referenced this pull request Nov 2, 2022
@hiSandog @EricGao888
[fix][sql] Add unique key to process_definition_log avoid TooManyResu…
ae77aa8 
…ltExpection (apache#12503)

* Add unique key to t_ds_process_definition_log
@EricGao888 EricGao888 mentioned this pull request Nov 2, 2022
Merged
EricGao888 added a commit that referenced this pull request Nov 2, 2022
@EricGao888 @hiSandog
[fix][sql] Add unique key to process_definition_log avoid TooManyResu…
4a70a93 
…ltExpection (#12503) (#12670)

* Add unique key to t_ds_process_definition_log

Co-authored-by: 陈家名 <13774486042@163.com>
@SbloodyS SbloodyS removed this from the 3.0.2 milestone Feb 7, 2023
@SbloodyS SbloodyS added this to the 3.1.4 milestone Feb 7, 2023
@unnunique unnunique mentioned this pull request Feb 20, 2023
Closed
3 tasks
@zhuangchong zhuangchong modified the milestones: 3.1.4, 3.1.5 Feb 21, 2023
zhuangchong pushed a commit that referenced this pull request Mar 30, 2023
@hiSandog @zhuangchong
cherry-pick [fix][sql] Add unique key to process_definition_log avoid…
ecfdebe 
… TooManyResultExpection

#12503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

@SbloodyS SbloodyS Awaiting requested review from SbloodyS

Assignees

@hiSandog hiSandog

Labels
backend bug Something isn't working
Projects
None yet
Milestone
3.1.5
6 participants
@hiSandog @codecov-commenter @EricGao888 @zhongjiajie @SbloodyS @zhuangchong