-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Optimizing data source centers #12292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@labbomb Please add some pr description, thanks~ |
down |
Codecov Report
@@ Coverage Diff @@
## dev #12292 +/- ##
============================================
- Coverage 39.71% 39.21% -0.51%
- Complexity 4193 4212 +19
============================================
Files 1016 1040 +24
Lines 38049 38795 +746
Branches 4363 4460 +97
============================================
+ Hits 15112 15214 +102
- Misses 21192 21807 +615
- Partials 1745 1774 +29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Please retry analysis of this Pull-Request directly on SonarCloud. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The front end part LGTM.
Purpose of the pull request
Add data source type page
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md