Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support run all level dependent when complement #11778

Merged
merged 9 commits into from
May 5, 2023
Merged

[Feature] Support run all level dependent when complement #11778

merged 9 commits into from
May 5, 2023

Conversation

stalary
Copy link
Contributor

@stalary stalary commented Sep 5, 2022 •
edited
Loading

Purpose of the pull request

Brief change log

Support all level dependent when complement

  1. Frontend add switch support user choose whether enable complement all level dependent process.
  2. Backends add find all level dependent process logic

child1 dependent parent, child2 and child2_1 dependent child1, the screenshot of the implementation is shown below
截屏2022-09-14 16 01 35
截屏2022-09-14 16 01 47
截屏2022-09-14 16 04 39
截屏2022-09-14 16 52 08

This pr whill close #11736

@github-actions github-actions bot added backend UI ui and front end related labels Sep 5, 2022
@SbloodyS SbloodyS added this to the 3.1.0 milestone Sep 6, 2022
@stalary stalary changed the title [Feature] Support all level dependent when complement [Feature] Support run all level dependent when complement Sep 9, 2022
@stalary stalary force-pushed the Feature-11736 branch 3 times, most recently from 1f35db5 to e85f049 Compare September 15, 2022 02:19
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022 •
edited
Loading

Codecov Report

Merging #11778 (cbf5de3) into dev (0a02522) will increase coverage by 0.01%.
The diff coverage is 75.00%.

❗ Current head cbf5de3 differs from pull request most recent head 24f2617. Consider uploading reports for the commit 24f2617 to get more accurate results

@@             Coverage Diff              @@
##                dev   #11778      +/-   ##
============================================
+ Coverage     38.20%   38.21%   +0.01%     
- Complexity     4434     4435       +1     
============================================
  Files          1220     1220              
  Lines         42706    42724      +18     
  Branches       4735     4738       +3     
============================================
+ Hits          16314    16326      +12     
- Misses        24587    24590       +3     
- Partials       1805     1808       +3
Impacted Files Coverage Δ
...inscheduler/api/controller/ExecutorController.java 17.94% <ø> (ø)
...che/dolphinscheduler/api/python/PythonGateway.java 16.94% <0.00%> (ø)
...cheduler/api/service/impl/ExecutorServiceImpl.java 51.49% <78.26%> (+1.11%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EricGao888 EricGao888 self-requested a review September 26, 2022 09:39
@stalary stalary closed this Sep 27, 2022
@stalary stalary reopened this Sep 27, 2022
@EricGao888
Copy link
Member

I just pulled your code and tested it locally, it looked good.
image

@EricGao888
Copy link
Member

I just pulled your code and tested it locally, it looked good. image

@stalary But the code doesn't seem rebased on the latest code. Could u plz pull the latest dev code and rebase again?

@EricGao888 EricGao888 mentioned this pull request Sep 27, 2022
Merged
4 tasks
@caishunfeng caishunfeng modified the milestones: 3.1.0, 3.2.0 Sep 27, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.8% 82.8% Coverage
0.0% 0.0% Duplication

SbloodyS
SbloodyS reviewed May 5, 2023
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please resolve conflicts.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@SbloodyS SbloodyS added feature new feature 3.2.0 for 3.2.0 version labels May 5, 2023
@SbloodyS SbloodyS merged commit d2f83ee into apache:dev May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SbloodyS SbloodyS SbloodyS approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@EricGao888 EricGao888 Awaiting requested review from EricGao888

Assignees

@stalary stalary

Labels
3.2.0 for 3.2.0 version backend feature new feature UI ui and front end related
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

[Feature][Dependent] Dependent support schedule all downstream recursively
5 participants
@stalary @codecov-commenter @EricGao888 @SbloodyS @caishunfeng