-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature-11195][UI] Add re-upload feature for resource files #11203
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #11203 +/- ##
============================================
- Coverage 39.46% 39.44% -0.02%
+ Complexity 4313 4308 -5
============================================
Files 1083 1083
Lines 40756 40756
Branches 4670 4673 +3
============================================
- Hits 16083 16075 -8
- Misses 22886 22895 +9
+ Partials 1787 1786 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8999dec
to
31d08c4
Compare
The code smell reported by SonarCloud is prevalent in the front-end code of the resource, do I need to resolve this? |
802744f
to
4eeb156
Compare
This PR only include front-end code, can it close #11195? I will remove the |
Yes, it can, the backend has been implemented |
4eeb156
to
f000e18
Compare
It’s better to reuse the upload logic instead of creating a new reupload. Because if the upload logic has changed, the reupload need to be changed too. There will be a bug in the feature.BTW, you can format your code by eslint. |
I thought about it again, let's imagine a very possible change, if uploading files later supports batch uploading or uploading folders, it may lead to bugs in re-uploading, and if processed separately, the function of re-uploading files uses different front-end code and different interface, it will not affect. |
The similarity reaches nearly eighty percent. I think it's better to reuse and handle the differences by parameters. |
ok~ |
cdd70d9
to
0c09827
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
54488a0
to
9cde6da
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@sketchmind @SbloodyS |
Pls resolve the conflicts. |
Sorry for that, I've already checked the front end side. it can be merged from the front end side. @SbloodyS pls check the back end side. |
…files * fix resource file incorrect button link * add re-upload feature for resource files * add re-upload feature for udf files * modify udf edit button to rename button * fix file resource page button-link constraint * encapsulate file and udf resource code * place the breadcrumbs in the upper left corner * optimized some code * modify relative e2e test * Fix the problem of UDF page breadcrumbs when using the browser to go back or forward * adapt to the latest resource center
9cde6da
to
41fa2c8
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
When will the version with the added feature of a 're-upload' button be updated? This feature is very practical |
This is a very creative feature request。When will the version with the added feature of a 're-upload' button be updated? |
Purpose of the pull request
Add re-upload feature for resource files
close #11195
Brief change log
[Feature-11195][UI] Add re-upload feature for resource files and udf files
Verify this pull request
Existing tests already cover part of this pull request, such as (please describe tests).
but reuploading resource feature should add more tests.