[RemoteLogging] Move init into loghandler (#15780)

Co-authored-by: 旺阳 <wang@lqwang.net>
apache · Mar 31, 2024 · d39bdcb · d39bdcb
1 parent dc4dad1
commit d39bdcb
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 36 deletions.
diff --git a/...mmon/src/main/java/org/apache/dolphinscheduler/common/log/remote/GcsRemoteLogHandler.java b/...mmon/src/main/java/org/apache/dolphinscheduler/common/log/remote/GcsRemoteLogHandler.java
@@ -49,19 +49,6 @@ public class GcsRemoteLogHandler implements RemoteLogHandler, Closeable {
     private static GcsRemoteLogHandler instance;
 
     private GcsRemoteLogHandler() {
-
-    }
-
-    public static synchronized GcsRemoteLogHandler getInstance() {
-        if (instance == null) {
-            instance = new GcsRemoteLogHandler();
-            instance.init();
-        }
-
-        return instance;
-    }
-
-    public void init() {
         try {
             credential = readCredentials();
             bucketName = readBucketName();
@@ -73,6 +60,14 @@ public void init() {
         }
     }
 
+    public static synchronized GcsRemoteLogHandler getInstance() {
+        if (instance == null) {
+            instance = new GcsRemoteLogHandler();
+        }
+
+        return instance;
+    }
+
     @Override
     public void close() throws IOException {
         try {

diff --git a/...mmon/src/main/java/org/apache/dolphinscheduler/common/log/remote/OssRemoteLogHandler.java b/...mmon/src/main/java/org/apache/dolphinscheduler/common/log/remote/OssRemoteLogHandler.java
@@ -44,28 +44,23 @@ public class OssRemoteLogHandler implements RemoteLogHandler, Closeable {
     private static OssRemoteLogHandler instance;
 
     private OssRemoteLogHandler() {
+        String accessKeyId = readOssAccessKeyId();
+        String accessKeySecret = readOssAccessKeySecret();
+        String endpoint = readOssEndpoint();
+        ossClient = OssClientFactory.buildOssClient(new OssConnection(accessKeyId, accessKeySecret, endpoint));
 
+        bucketName = readOssBucketName();
+        checkBucketNameExists(bucketName);
     }
 
     public static synchronized OssRemoteLogHandler getInstance() {
         if (instance == null) {
             instance = new OssRemoteLogHandler();
-            instance.init();
         }
 
         return instance;
     }
 
-    public void init() {
-        String accessKeyId = readOssAccessKeyId();
-        String accessKeySecret = readOssAccessKeySecret();
-        String endpoint = readOssEndpoint();
-        ossClient = OssClientFactory.buildOssClient(new OssConnection(accessKeyId, accessKeySecret, endpoint));
-
-        bucketName = readOssBucketName();
-        checkBucketNameExists(bucketName);
-    }
-
     @Override
     public void sendRemoteLog(String logPath) {
         String objectName = RemoteLogUtils.getObjectNameFromLogPath(logPath);

diff --git a/...ommon/src/main/java/org/apache/dolphinscheduler/common/log/remote/S3RemoteLogHandler.java b/...ommon/src/main/java/org/apache/dolphinscheduler/common/log/remote/S3RemoteLogHandler.java
@@ -56,28 +56,23 @@ public class S3RemoteLogHandler implements RemoteLogHandler, Closeable {
     private static S3RemoteLogHandler instance;
 
     private S3RemoteLogHandler() {
-
+        accessKeyId = readAccessKeyID();
+        accessKeySecret = readAccessKeySecret();
+        region = readRegion();
+        bucketName = readBucketName();
+        endPoint = readEndPoint();
+        s3Client = buildS3Client();
+        checkBucketNameExists(bucketName);
     }
 
     public static synchronized S3RemoteLogHandler getInstance() {
         if (instance == null) {
             instance = new S3RemoteLogHandler();
-            instance.init();
         }
 
         return instance;
     }
 
-    public void init() {
-        accessKeyId = readAccessKeyID();
-        accessKeySecret = readAccessKeySecret();
-        region = readRegion();
-        bucketName = readBucketName();
-        endPoint = readEndPoint();
-        s3Client = buildS3Client();
-        checkBucketNameExists(bucketName);
-    }
-
     protected AmazonS3 buildS3Client() {
         if (StringUtils.isNotEmpty(endPoint)) {
             return AmazonS3ClientBuilder