Skip to content

Commit

Permalink
[Bug] Fix endless loop (#15092)
Browse files Browse the repository at this point in the history
* [fix-#13045] fix endless loop

---------

Co-authored-by: fuchanghai <‘2875334588@qq.com’>
  • Loading branch information
fuchanghai and fuchanghai authored Nov 8, 2023
1 parent 5e135ba commit 2622685
Show file tree
Hide file tree
Showing 2 changed files with 74 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public void handleWorkflowEvent(final WorkflowEvent workflowEvent) throws Workfl
}
} else if (WorkflowStartStatus.FAILED == workflowStartStatus) {
log.error(
"Failed to submit the workflow instance, will resend the workflow start event: {}",
"Failed to submit the workflow instance, will send fail state event: {}",
workflowEvent);
WorkflowStateEvent stateEvent = WorkflowStateEvent.builder()
.processInstanceId(processInstance.getId())
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.dolphinscheduler.server.master.event;

import org.apache.dolphinscheduler.common.enums.StateEventType;
import org.apache.dolphinscheduler.dao.entity.ProcessInstance;
import org.apache.dolphinscheduler.server.master.metrics.ProcessInstanceMetrics;
import org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteRunnable;

import lombok.extern.slf4j.Slf4j;

import com.google.auto.service.AutoService;

@AutoService(StateEventHandler.class)
@Slf4j
public class WorkflowSubmitFailStateEventHandler implements StateEventHandler {

@Override
public boolean handleStateEvent(WorkflowExecuteRunnable workflowExecuteRunnable,
StateEvent stateEvent) throws StateEventHandleException {
WorkflowStateEvent workflowStateEvent = (WorkflowStateEvent) stateEvent;
ProcessInstance processInstance =
workflowExecuteRunnable.getWorkflowExecuteContext().getWorkflowInstance();
measureProcessState(workflowStateEvent, processInstance.getProcessDefinitionCode().toString());
log.info(
"Handle workflow instance submit fail state event, the current workflow instance state {} will be changed to {}",
processInstance.getState(), workflowStateEvent.getStatus());

workflowExecuteRunnable.updateProcessInstanceState(workflowStateEvent);
workflowExecuteRunnable.endProcess();
return true;
}

@Override
public StateEventType getEventType() {
return StateEventType.PROCESS_SUBMIT_FAILED;
}

private void measureProcessState(WorkflowStateEvent processStateEvent, String processDefinitionCode) {
if (processStateEvent.getStatus().isFinished()) {
ProcessInstanceMetrics.incProcessInstanceByStateAndProcessDefinitionCode("finish", processDefinitionCode);
}
switch (processStateEvent.getStatus()) {
case STOP:
ProcessInstanceMetrics.incProcessInstanceByStateAndProcessDefinitionCode("stop", processDefinitionCode);
break;
case SUCCESS:
ProcessInstanceMetrics.incProcessInstanceByStateAndProcessDefinitionCode("success",
processDefinitionCode);
break;
case FAILURE:
ProcessInstanceMetrics.incProcessInstanceByStateAndProcessDefinitionCode("fail", processDefinitionCode);
break;
default:
break;
}
}
}

0 comments on commit 2622685

Please sign in to comment.