core/tests/parquet/row_group_pruning.rs: Add tests for strings #9642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progval
force-pushed
the
string-pruning-test
branch
from
70ea744
to
ed73847
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9641.
Rationale for this change
They were only locally tested in
datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs, and not as exhaustively as they can be here.What changes are included in this PR?
In addition to the new tests, I added a new fixture with
String,Binary, andFixedSizeBinarycolumns. The latter two are not used yet, but I have some code locally that uses them after I added support for bloom filters on these column types.Are these changes tested?
Are there any user-facing changes?
None