fix: coalesce function should return correct data type #9459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Dandandan
approved these changes
Mar 5, 2024
|
Some remaining test failures are unrelated. But some seem related. I'll keep looking into them. |
viirya
commented
Mar 5, 2024
Comment on lines
+421
to
+423
| if *type_into == coerced_type { | ||
| Some(coerced_type) | ||
| } else { |
There was a problem hiding this comment.
For function argument, we want to coerce to exact the type (valid type) instead of third type.
viirya
commented
Mar 5, 2024
Comment on lines
+96
to
100
| "could not cast {} from {} to {}", | ||
| $NAME, | ||
| $ARG.data_type(), | ||
| type_name::<$ARRAY_TYPE>() | ||
| )) |
There was a problem hiding this comment.
When I debug, I found that it is a more useful error message to show the source data type too.
|
Thanks @Dandandan |
wiedld
pushed a commit
to wiedld/arrow-datafusion
that referenced
this pull request
Apr 1, 2024
* fix: Remove supported coalesce types * Use comparison_coercion * Fix test * Fix * Add comment * More * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9458.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?