Minor: improve dataframe functional dependency tests #8630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR |
alamb
commented
Dec 26, 2023
| )); | ||
| // Predicate refers to id, and name fields: | ||
| // id = 1 AND name = 'a' | ||
| let predicate = col("id").eq(lit(1i32)).and(col("name").eq(lit("a"))); |
There was a problem hiding this comment.
I think the expr API is more concise and makes it easer to quickly understand what expression is being created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #8628
While working on #8629 I found it hard at first to understand what these tests (added in #8356) were attempting to validate, largely because of some boilerplate / repetition that made them harder for me to understand
I am also trying to leave the DataFusion codebase always slightly better than when I found it.
What changes are included in this PR?
Reduce duplication and improve comments
Are these changes tested?
only tests
Are there any user-facing changes?
No, this is cleanup only