Implement logical plan serde for CopyTo #8618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
Dec 21, 2023
viirya
reviewed
Dec 21, 2023
Comment on lines
355
to
356
| println!("{plan:?}"); | ||
| println!("{logical_round_trip:?}"); |
There was a problem hiding this comment.
Oops, no. Thanks for catching that. I have removed it.
Dandandan
approved these changes
Dec 22, 2023
|
TY @andygrove ! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8596
Rationale for this change
Implement serde for
CopyTobecause it is needed by Ballista (apache/datafusion-ballista#894).What changes are included in this PR?
Implement serde and add unit tests.
There is a follow-on issue #8619 to add support for CopyTo with WriterOptions, which for now is unsupported and will return an
Err.Are these changes tested?
Yes.
Are there any user-facing changes?