feat: support LargeList in array_dims
#8592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
comphead
reviewed
Dec 20, 2023
| @@ -1925,12 +1925,29 @@ pub fn array_length(args: &[ArrayRef]) -> Result<ArrayRef> { | |||
|
|
|||
| /// Array_dims SQL function | |||
| pub fn array_dims(args: &[ArrayRef]) -> Result<ArrayRef> { | |||
| let list_array = as_list_array(&args[0])?; | |||
| let data = match args[0].data_type() { | |||
There was a problem hiding this comment.
please check args not empty, especially if its pub function
There was a problem hiding this comment.
I will address this later in the pull request as other functions may also lack this check.
comphead
reviewed
Dec 20, 2023
| query ??? | ||
| select array_dims(arrow_cast(make_array(1, 2, 3), 'LargeList(Int64)')), array_dims(arrow_cast(make_array([1, 2], [3, 4]), 'LargeList(List(Int64))')), array_dims(arrow_cast(make_array([[[[1], [2]]]]), 'LargeList(List(List(List(List(Int64)))))')); | ||
| ---- | ||
| [3] [2, 2] [1, 1, 1, 2, 1] |
comphead
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Parts #8185
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?