Support multi column IN lists #8590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
reviewed
Dec 22, 2023
There was a problem hiding this comment.
This looks very neat @my-vegetable-has-exploded -- the only other thing this PR needs I think is some end to end .slt tests and then it would be good to go
|
BTW filed apache/arrow-rs#5234 to track releasing the next arrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6635.
Rationale for this change
What changes are included in this PR?
sql_expr_to_logical_expr_internalreturnResult<Expr>, butStruct(Option<Vec<ScalarValue>>, Fields)need ScalarValue, I think it is ok to let physical-expr to handle the downcast process.Are these changes tested?
Here is the draft pr. I feel like this is enough to finish the issue. Maybe you can take a first look when you are free.
I will add some tests after apache/arrow-rs#5217 merged and version updated.
Are there any user-facing changes?