Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add primary key support to stream table #8467

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Add primary key support to stream table #8467

merged 1 commit into from
Dec 8, 2023

Conversation

mustafasrepo
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Currently, when we create unbounded external table StreamTable do not use Constraints e.g (PRIMARY KEY, UNIQUE, etc.) This PR adds this support to StreamTable.

With this PR we can run following query (where column c is PRIMARY KEY of the table unbounded_multiple_ordered_table_with_pk)

SELECT c, a, SUM(d)
FROM unbounded_multiple_ordered_table_with_pk
GROUP BY c
ORDER BY c
LIMIT 5

What changes are included in this PR?

Are these changes tested?

Yes, above mentioned test is added.

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Dec 8, 2023
ozankabak
ozankabak approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @alamb

alamb
alamb approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mustafasrepo

@alamb alamb merged commit 34b0445 into apache:main Dec 8, 2023
22 checks passed
appletreeisyellow pushed a commit to appletreeisyellow/datafusion that referenced this pull request Dec 15, 2023
@mustafasrepo @appletreeisyellow
Add primary key support to stream table (apache#8467)
6991435
@matthewgapp matthewgapp mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@ozankabak ozankabak ozankabak approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mustafasrepo @alamb @ozankabak