Minor: refactor bloom filter tests to reduce duplication #8435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
alamb
force-pushed
the
alamb/less_test_copy_pasta2
branch
from
3913a35
to
01198eb
Compare
alamb
force-pushed
the
alamb/less_test_copy_pasta2
branch
from
b582b4d
to
08a274a
Compare
korowa
reviewed
Dec 27, 2023
| assert!(pruned_row_groups.is_empty()); | ||
| BloomFilterTest::new_data_index_bloom_encoding_stats() | ||
| .with_expect_all_pruned() | ||
| // generate pruning predicate `(String = "Hello_Not_exists" OR String = "Hello_Not_exists2")` |
There was a problem hiding this comment.
A bit controversial due to "1" = "1" part in actual test case expression.
There was a problem hiding this comment.
I agree -- I am not sure what the "1" = "1" is all about. @haohuaijin or @waynexia do you remember?
korowa
approved these changes
Dec 27, 2023
|
@waynexia or @yahoNanJing could I perhaps request your review of this PR? I can not merge it without another committer's review:
|
|
Thank you @Ted-Jiang 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #8433
Rationale for this change
The bloom filter tests have substantial duplication which makes it hard to see what they are trying to test. This PR refactors out the common pattern making the tests clearer to understand
What changes are included in this PR?
Refactor BoomFilter tests
Are these changes tested?
All tests
Are there any user-facing changes?