Support crossjoin in substrait. #8427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
alamb
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Thank you for the contribution @my-vegetable-has-exploded this looks great to me. I had a small suggestion to improve the code but I don't think it is necessary
waynexia
approved these changes
Dec 6, 2023
|
🎉 |
36 tasks
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Dec 15, 2023
* Support crossjoin in substrait. * use struct destructuring * remove useless builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ref: #8149
Closes #.
Rationale for this change
part of #8149.
What changes are included in this PR?
Translate cross product to LogicalPlan::CrossJoin.
Are these changes tested?
Are there any user-facing changes?