Support LargeUtf8 to Temporal Coercion #8357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
github-actions
bot
added
logical-expr
jayzhan211
commented
Nov 29, 2023
| } | ||
|
|
||
| match_rule(lhs_type, rhs_type).or_else(|| match_rule(rhs_type, lhs_type)) |
There was a problem hiding this comment.
without this it will be too hard to check if the code cover one type.
There was a problem hiding this comment.
This is a neat construction 👍
jayzhan211
changed the title
8 tasks
alamb
approved these changes
Nov 30, 2023
| } | ||
|
|
||
| match_rule(lhs_type, rhs_type).or_else(|| match_rule(rhs_type, lhs_type)) |
There was a problem hiding this comment.
This is a neat construction 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Ref #8302
Rationale for this change
There are two reason why I want to support this coercion.
One is that
LargeUtf8toTimestampis supported incoerced_from. We need the same so I can replace it withstring_temporal_coercionSecond is that comment in
string_temporal_coercionmentionedLargeUtf8but the code itself does not.What changes are included in this PR?
Are these changes tested?
I didnt find coercion test in slt. I put it in
scalar.sltfor now.Are there any user-facing changes?