Minor: Make schema of grouping set columns nullable #8248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusa380
changed the title
|
it works for me. 👍 |
yukkit
approved these changes
Nov 17, 2023
github-actions
bot
added
optimizer
|
@Dandandan could you approve the workflows again? I had to fix some tests. |
|
Thanks @markusa380 and @Dandandan and @yukkit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8247.
Rationale for this change
In our project using datafusion, we have a specific optimizer rule that combines an aggregation into a different node.
We noticed that when creating the results using
RecordBatch::try_new(...)using the schmea of the aggregation, it fails as it expects the columns to be non-nullable if the input column is non-nullable in case of grouping sets, although naturally all rows that do not belong to the "current" grouping set are null for that column.So, this PR will force the field created from a grouping set to be nullable.
What changes are included in this PR?
Are these changes tested?
Added a unit test.
Are there any user-facing changes?
No.