Minor: remove duplicated array_replace tests
#8066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
commented
Nov 6, 2023
| select array_replace(make_array([1, 2, 3], [4, 5, 6], [5, 5, 5], [4, 5, 6], [7, 8, 9]), [4, 5, 6], [1, 1, 1]), array_replace(make_array([1, 3, 2], [2, 3, 4], [2, 3, 4], [5, 3, 1], [1, 3, 2]), [2, 3, 4], [3, 1, 4]); | ||
| select | ||
| array_replace( | ||
| make_array([1, 2, 3], [4, 5, 6], [5, 5, 5], [4, 5, 6], [7, 8, 9]), |
There was a problem hiding this comment.
by rewriting with some whitespace, I think it is much easier now to see what this test is covering
|
I wonder what you think of this @jayzhan211 ? If you agree that this is an improvement, I can do the same for the other tests in |
Nice improvement. We should move test to slt file if possible! |
jackwener
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #7988
Rationale for this change
As pointed out by @jayzhan211 in #8054 (comment), sqllogictests tests are easier to maintain and also cover the logic end to end.
I was going to port the rest of the tests for
array_replacetoarray.sltand when I went to do so I found out they were already there.What changes are included in this PR?
array_expressions.rsarray.sltto make it clearer what is tested (and in particular all the cases are already covered)Are these changes tested?
Yes, by existing tests
Are there any user-facing changes?
No