Minor: Fix docstring typos #7873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
Oct 19, 2023
alamb
commented
Oct 19, 2023
| @@ -65,7 +65,7 @@ Environment variables are read during `SessionConfig` initialisation so they mus | |||
| | datafusion.execution.parquet.max_statistics_size | NULL | Sets max statistics size for any column. If NULL, uses default parquet writer setting | | |||
| | datafusion.execution.parquet.max_row_group_size | 1048576 | Sets maximum number of rows in a row group | | |||
| | datafusion.execution.parquet.created_by | datafusion version 32.0.0 | Sets "created by" property | | |||
| | datafusion.execution.parquet.column_index_truncate_length | NULL | Sets column index truncate length | | |||
| | datafusion.execution.parquet.column_index_truncate_length | NULL | Sets column index trucate length | | |||
There was a problem hiding this comment.
I am not sure why this is required on this PR (maybe the CI didn't fully run on another PR 🤔 ) anyhow it seems a straightforward enough fix
There was a problem hiding this comment.
🤔 it is -- but that seems to have been introduced in #7244
I am very confused. Let's merge this PR and I'll make another one to fix that typo
There was a problem hiding this comment.
#7874 to fix that one too
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #7840 (review)
Rationale for this change
@viirya found several typos #7840 (review) 🤦
What changes are included in this PR?
Fix the typos
Are these changes tested?
Are there any user-facing changes?